beaker key generate should allow 12 or 24 words

osmosis-labs / beaker

Beaker helps streamlining CosmWasm development workflow.

Apache License 2.0

106 stars 30 forks source link

beaker key generate should allow 12 or 24 words #88

Open daniel-farina opened 2 years ago

daniel-farina commented 2 years ago

Currently it only supports 24 words mnemonics. Example:

beaker key set test 'praise wagon resist capital oxygen bounce vivid jacket pool crime embody dress'
Error: Invalid phrase, if word length is not 24, please consider using 24-words mnemonic
Caused by:
    bip39 error

iboss-ptk commented 2 years ago

This is a bip32 lib limitation which has fixed entropy. I don't think it would make sense to support unless there is a strong case for it.

Let me know if you think otherwise.

ValarDragon commented 2 years ago

Agreed, I also don't think the envisioned usage of beaker needs robust key management. Its just for test keys, and a 12 word restriction seems fine for rn to me.

Eventually we'll just get more key things as a shim over osmosisd presumably.

iboss-ptk commented 2 years ago

@ValarDragon FFI to Go might make sense down the road I think. So user doesn't need to install the whole osmosisd.

daniel-farina commented 2 years ago

sounds good!