chore: Revert "chore: bump go 1.18; bump Tendermint (#321)" - Githubissues

osmosis-labs / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:

https://cosmos.network/

Apache License 2.0

14 stars 34 forks source link

chore: Revert "chore: bump go 1.18; bump Tendermint (#321)" #328

Closed p0mvn closed 2 years ago

p0mvn commented 2 years ago

This reverts commit 01fda2a5331eead2a139ff2f338d6ad8b902e16b.

Closes: #XXX

What is the purpose of the change

Reverting tm v0.34.21

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented? not applicable

czarcas7ic commented 2 years ago

Are all these go reverts to 1.16 required/desired?

czarcas7ic commented 2 years ago

What I mean is, should we decouple the go bump from the tendermint bump?

ValarDragon commented 2 years ago

I'm ok reverting everything here personally, all part of the bug surface area

alexanderbez commented 2 years ago

Are we reverting this just to tag an SDK version compatible with v12?

These changes are a requirement and a foundation for ABCI++ work to land. It's also a prerequisite for https://github.com/osmosis-labs/cosmos-sdk/pull/324.

p0mvn commented 2 years ago

Are we reverting this just to tag an SDK version compatible with v12?

These changes are a requirement and a foundation for ABCI++ work to land. It's also a prerequisite for #324.

osmosis-main will not have anything reverted so it should be fine for any future work depending on this

alexanderbez commented 2 years ago

Ahh derp, my bad! I didn't see the base branch 😆

ACK