feat: ABCI 1.0 Phase I Completion

osmosis-labs / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:

https://cosmos.network/

Apache License 2.0

14 stars 34 forks source link

feat: ABCI 1.0 Phase I Completion #382

Closed alexanderbez closed 1 year ago

alexanderbez commented 1 year ago

Changelog

Downstream changes from the core SDK repo that contains the necessary components for ABCI 1.0 phase I completion. This includes but is not limited to:
- PrepareProposal support
- ProcessProposal support
- Default nonce-based Mempool
- Default PrepareProposal handler
- Default ProcessProposal handler

alexanderbez commented 1 year ago

So this PR is essentially blocked on getting the repo migrated to use cosmos/gogoproto instead of the deprecated github.com/gogo/protobuf, due to Tendermint also migrating (v0.37.x).

I've started this work here: https://github.com/osmosis-labs/cosmos-sdk/pull/383

Currently blocked on getting it across the finish line...

alexanderbez commented 1 year ago

Sorry @p0mvn didn't mean to waste your time on reviewing the (default) mempool implementation. The implementation was actually changed to be by random sender, instead of lowest-nonce. So this should give a reasonably more fair mempool. However, there are still DoS vectors. Regardless, this is just the default implementation and not something Osmosis will even use anyway.