osmosis-labs / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Apache License 2.0
14 stars 34 forks source link

fix: Downgrade and replace Tendermint verison to Informal/tendermint v0.34 #420

Closed mattverse closed 1 year ago

mattverse commented 1 year ago

What is the purpose of the change

Current Osmosis(https://github.com/osmosis-labs/osmosis) tendermint dependency is using informal / tendermint with the verison of v0.34 (https://github.com/osmosis-labs/osmosis/blob/main/go.mod#L320).

Instead of using dependencies from two different sources, we should change this so that we use the same tendermint version for the two different repositories(sdk and osmosis).

Seems like tendermint version was bumped to v0.37 in a PR of ABCI 1.0 integration, (https://github.com/osmosis-labs/cosmos-sdk/pull/345/files) upon CI passing it should be safe to down grade and replace the tendermint dependecy used here to informal tendermint 0.34

Brief Changelog

Testing and Verifying

Exisitng tests pass and CI passes

Documentation and Release Note

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.