osmosis-labs / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Apache License 2.0
14 stars 31 forks source link

chore: Remove burn logs from Bank module #432

Closed mattverse closed 1 year ago

mattverse commented 1 year ago

Closes: https://github.com/osmosis-labs/osmosis/issues/4540

What is the purpose of the change

Removes Burn Logs from Bank module.

We have alot of incidences where we Burn coins, for example, whenever user exits a pool, it would burn the pool shares, triggering this log layer.

We also have future incidences where we will have multiples of simultaneous burns, e,g when we are migrating shares from one pool to other. This would cause log bombs in nodes as shown in the original issue.

This PR removes log bombs caused from burns.

Brief Changelog

Testing and Verifying

This change does not need tests

Documentation and Release Note

czarcas7ic commented 1 year ago

Is there any desire to keep this as a log but for debug mode only?

mattverse commented 1 year ago

@czarcas7ic yes definitely! Nice suggestion, changed!