search

osmosis-labs / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Apache License 2.0
14 stars 31 forks source link

fix: added expedited quorum param v0.47 #457

Closed stackman27 closed 1 year ago

stackman27 commented 1 year ago

Closes: #XXX

What is the purpose of the change

We should have a higher quorum requirement for expedited to be 2/3 of the voting power to be consistent with the original proposal. Currently, it is 0.2 quorum where 2/3 must have voted yes. So there is no code error but a mismatch between code logic and the desired behavior. I think that the direction should be to modify the logic pre-v16 to be consistent with #278 prop where there is an expedited-specific quorum param. We can announce this change as part of the v16 upgrade.

Brief Changelog

Testing and Verifying

czarcas7ic commented 1 year ago

Please slack ping me when this is passing CI

julienrbrt commented 1 year ago

We've up streamed expedited proposals for Cosmos SDK Eden (0.5) from your fork. If this gets merged, would you mind up streaming this to the SDK?