Using iavl v1.0.0 with cosmos sdk 0.47.5 - Githubissues

osmosis-labs / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:

https://cosmos.network/

Apache License 2.0

14 stars 31 forks source link

Using iavl v1.0.0 with cosmos sdk 0.47.5 #495

Closed hieuvubk closed 6 months ago

hieuvubk commented 9 months ago

Closes: #XXX

What is the purpose of the change

Add a description of the overall background and high-level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....

Brief Changelog

(for example:)

The metadata is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
Daemons retrieve the RPC data from the blob cache

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Added unit test that validates ...
Added integration tests for end-to-end deployment with ...
Extended integration test for ...
Manually verified the change by ...

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

faddat commented 9 months ago

Fyi, on the PR I made, we got a super helpful comment from @julienbrt

https://github.com/julienrbrt/cosmos-sdk-inj/compare/f/v0.47.3-inj-1...ac1b893f08942b97c308dc57716cf8c597ef967f

github-actions[bot] commented 6 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

czarcas7ic commented 6 months ago

Closing, since we currently are using a different branch for this