fix: RegisterLegacyAminoCodec should error if Msg name is >39 chars

[mattverse]

Description

Closes: https://github.com/osmosis-labs/osmosis/issues/1106, backport https://github.com/cosmos/cosmos-sdk/pull/11349

What is the purpose of the change

Fixes so that RegisterLegacyAminoCodec errors if Msg name is >39 chars, this has been a long bug that has not been addressed for a long time.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

• [ ] included the correct type prefix in the PR title
• [ ] added ! to the type prefix if API or client breaking change
• [ ] targeted the correct branch (see PR Targeting)
• [ ] provided a link to the relevant issue or specification
• [ ] followed the guidelines for building modules
• [ ] included the necessary unit and integration tests
• [ ] added a changelog entry to CHANGELOG.md
• [ ] included comments for documenting Go code
• [ ] updated the relevant documentation or specification
• [ ] reviewed "Files changed" and left comments if necessary
• [ ] run make lint and make test
• [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

• [ ] confirmed the correct type prefix in the PR title
• [ ] confirmed ! in the type prefix if API or client breaking change
• [ ] confirmed all author checklist items have been addressed
• [ ] reviewed state machine logic
• [ ] reviewed API design and naming
• [ ] reviewed documentation is accurate
• [ ] reviewed tests and test coverage
• [ ] manually tested (if applicable)

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[czarcas7ic]

@mattverse can this be revived against the osmo/v0.47.5 branch?

Also, wouldn't it make more sense to just add this directly to osmosis? Since we aren't going to be registering any custom messages generally direct to sdk, and keeps us further from the fork (unless you are going to upstream)

[ValarDragon]

Based on ledger updates per matt, seems like we can actually close!