chore: add missing proto fields to gov v1 - Githubissues

osmosis-labs / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:

https://cosmos.network/

Apache License 2.0

14 stars 31 forks source link

chore: add missing proto fields to gov v1 #497

Closed PaddyMc closed 9 months ago

PaddyMc commented 9 months ago

What is the purpose of the change

Adding missing proto fields to gov

Problem

When starting a node from scratch it fails, as we can't find the params below

panic: unknown field "min_expedited_deposit" in v1.DepositParams

goroutine 26 [running]:
github.com/cosmos/cosmos-sdk/codec.(*ProtoCodec).MustUnmarshalJSON(0x0?, {0xc001229400?, 0x0?, 0x0?}, {0x3b98020?, 0xc000ac6380?})
    github.com/cosmos/cosmos-sdk@v0.47.5/codec/proto_codec.go:187 +0x45

How to test

run a node on main in the osmosis repo
then checkout out this branch
run make proto-gen
link this branch to the osmosis node
run the node