Closed mattverse closed 5 months ago
@czarcas7ic should this be good to go ahead and merge?
This update enhances error handling across various governance-related functions within the codebase. It introduces modifications to ensure that errors in hooks execution are properly handled and returned, improving the robustness and reliability of the governance process. The changes span across the EndBlocker
, AddDeposit
, SubmitProposal
, and AddVote
functions, alongside updates to the GovHooks
interface and tests to align with the new error handling approach.
Files | Change Summary |
---|---|
x/gov/abci.go , .../keeper/deposit.go , .../keeper/proposal.go , .../keeper/vote.go |
Enhanced error handling in EndBlocker , AddDeposit , SubmitProposal , and AddVote functions. |
x/gov/keeper/hooks_test.go |
Updated MockGovHooksReceiver functions to explicitly return nil . |
x/gov/types/expected_keepers.go , x/gov/types/hooks.go |
Updated GovHooks interface and implemented error handling with JoinErrors in MultiGovHooks . |
🐰✨
In a land of code and bytes, where governance reigns,
A rabbit hopped, spreading updates, easing pains.
"No more silent errors," it cheerfully claims,
Through proposals and votes, it aims.
With a hop, skip, and a jump, errors it tames,
In the blockchain world, it leaves its marks, not just names.
🌟🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Backport of upstream PR#18173, upstream PR #19305
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit