Closed ValarDragon closed 1 month ago
This update introduces enhancements and new functionalities to address conversion and validation, focusing on Bech32 address handling. Key improvements include the addition of functions for trusted Bech32 address conversion, a method to decode Bech32 encoded strings to base64 bytes without checksum verification, and refined error handling. These changes aim to streamline address processing while ensuring reliability and error resilience.
Files | Change Summary |
---|---|
types/address.go |
Added functions for trusted Bech32 address conversion, enhanced validation, and improved error handling. |
types/bech32/bech32.go types/bech32/bech32_test.go |
Introduced TrustedDataDecodeAndConvert and added test cases, including a fuzzing test for reliability. |
🐇✨
In the realm of code, where addresses align,
A rabbit hopped through, improvements to find.
With Bech32 in hand, and errors at bay,
It crafted new functions, in a magical way.
"To trust and to validate," it sang with glee,
Ensuring the data, as safe as can be.
🌟🐰
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
For tracking purposes, is this something that is upstreamed to the sdk already?
It is not, was thinking of just testing state compat for Osmosis pools, and something in staking, then upstreaming
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
We should use this to speedup operations with decoding addresses in Osmosis.
I'd expect a .3% sync speedup from just using this in the CL module.
Summary by CodeRabbit