search

osmosis-labs / isotonic

Smart Contracts for the Lendex Protocol
MIT License
1 stars 0 forks source link

Rename `base_asset` to `market_token` #44

Closed ueco-jb closed 2 years ago

ueco-jb commented 2 years ago 
sed -i "s/base_asset/market_token/g" $(find . -name "*.rs")

I think that name better represents what this asset actually is. Plus it matches better with added later common_token passed down from Credit Agency.

ethanfrey commented 2 years ago

Someone else please review/comment.

I am bad at naming (as I am sure you have figured out)

uint commented 2 years ago

I guess token is more descriptive and concrete than asset. Sounds cool with me.

The base part is what feels weird to me TBH when used in the market/agency contracts. traded_token? So we'd have a reward_token, common_token and then a bunch of traded_tokens.

ueco-jb commented 2 years ago

The base part is what feels weird to me TBH when used in the market/agency contracts. traded_token?

Problem here is basically "local" denom (per market) vs "global" (per credit agency) - I think like that's the most important thing that those names should carry, to prevent confusion.

EDIT: Maybe market_token would be good name (instead of local)? Then we have market_token and common_token.

uint commented 2 years ago

EDIT: Maybe market_token would be good name (instead of local)? Then we have market_token and common_token.

I don't like local_token, but market_token is 10/10. If I know I'm creating different markets, I'd instantly know what it's for based on the name.