osmosis-labs / isotonic

Smart Contracts for the Lendex Protocol
MIT License
1 stars 0 forks source link

Figure out integration tests against actual Osmosis #88

Open uint opened 2 years ago

uint commented 2 years ago

This is about having some sort of CI integration tests against actual Osmosis code (whether it's a small network, one node, whatever).

Cake will be available at the conclusion of these tests.

ethanfrey commented 2 years ago

I assume the tests will be written in CosmJS (which is how we do all full stack integration currently).

It would be good to consider borrowing some time for the fronted devs (Maybe Abel, maybe Milan) to work on this. Ethan or Alex or Simon should be able set up a CI framework if needed - to run the chain and upload the contracts. The team should write all further tests

ueco-jb commented 2 years ago

I'm marking it as blocked for now. CI works well, but since I removed "old" oracle's contract (and didn't realize that we are still waiting osmosis support for the new one) - it won't work right now. For example, calling register_pool() message currently will either crash or won't work at all. https://github.com/confio/isotonic/blob/main/contracts/isotonic-osmosis-oracle/src/msg.rs#L15-L19

ueco-jb commented 2 years ago

Osmosis developed contenerized project that spins up Osmosis network: https://github.com/osmosis-labs/LocalOsmosis We can use it to make sure it won't crash on actual mainnet. First do some manual testing, then script it into CI.

ueco-jb commented 2 years ago

If Osmosis will not actually use Isotonic and want to reuse most of its code for another project, then live tests might not be required.

ethanfrey commented 2 years ago

Did someone say cake?