search

osmosis-labs / isotonic

Smart Contracts for the Lendex Protocol
MIT License
1 stars 0 forks source link

Optimization: Entering markets #91

Closed uint closed 2 years ago

uint commented 2 years ago

Closes #24

I'm trying to make it a "transparent optimization" as described in the slab article. Doing it explicitly would make it necessary to adjust our tests a fair bit. Doing it transparently probably means we can keep tests exactly as they were.

uint commented 2 years ago

Since it's an optimization, it'd be a bit difficult to test, but the fact our existing tests are still green is a hint everything still works.

ueco-jb commented 2 years ago

it'd be a bit difficult to test,

Would benchmarking pre and post your changes help? criterion etc.

uint commented 2 years ago

Would benchmarking pre and post your changes help? criterion etc.

Maybe! I think if we wanted to set up benchmarks, we'd ideally want something Cosmwasm-specific that compares gas costs or whatever. But I think performance testing is out of scope for this PR and not a priority anyway.