Closed uint closed 10 months ago
Initial review of the price provider. Will take a look at the consumer next.
Hey @maurolacy! I appreciate the review, but there's no need to go so in-depth when this is still a draft, pending a cleanup. I feel like the energy is better spent taking a high level view and verifying if this is what we want. I'll address the comments on Monday. Till then!
Thanks for the pointer. Put some comments there as well.
Attention: 321 lines
in your changes are missing coverage. Please review.
Comparison is base (
c20eecc
) 88.40% compared to head (1dfb124
) 87.18%. Report is 16 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Alright, I won't stall more. I'll try to add some tests in a separate PR for what I can, although there's very little non-IBC logic here.
Maybe closes #99
sdk.Dec
gotten fromarithmetic_twap_to_now
is stringified