osmosis-labs / mesh-security

Other
62 stars 8 forks source link

Slashing improvements #163

Closed maurolacy closed 10 months ago

maurolacy commented 10 months ago

Some improvements / fixes done in passing during #162 impl.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (1720b41) 87.69% compared to head (55e1eaa) 88.45%. Report is 13 commits behind head on 129/native-slashing-acct.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 129/native-slashing-acct #163 +/- ## ============================================================ + Coverage 87.69% 88.45% +0.75% ============================================================ Files 70 69 -1 Lines 13216 13466 +250 Branches 13216 13466 +250 ============================================================ + Hits 11590 11911 +321 + Misses 1092 1011 -81 - Partials 534 544 +10 ``` | [Files](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs) | Coverage Δ | | |---|---|---| | [...ider/native-staking/src/native\_staking\_callback.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-Y29udHJhY3RzL3Byb3ZpZGVyL25hdGl2ZS1zdGFraW5nL3NyYy9uYXRpdmVfc3Rha2luZ19jYWxsYmFjay5ycw==) | `58.33% <100.00%> (ø)` | | | [contracts/provider/native-staking/src/state.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-Y29udHJhY3RzL3Byb3ZpZGVyL25hdGl2ZS1zdGFraW5nL3NyYy9zdGF0ZS5ycw==) | `100.00% <ø> (ø)` | | | [contracts/provider/vault/src/multitest.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-Y29udHJhY3RzL3Byb3ZpZGVyL3ZhdWx0L3NyYy9tdWx0aXRlc3QucnM=) | `99.91% <100.00%> (+<0.01%)` | :arrow_up: | | [packages/apis/src/virtual\_staking\_api.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-cGFja2FnZXMvYXBpcy9zcmMvdmlydHVhbF9zdGFraW5nX2FwaS5ycw==) | `50.00% <ø> (ø)` | | | [packages/bindings/src/lib.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-cGFja2FnZXMvYmluZGluZ3Mvc3JjL2xpYi5ycw==) | `0.00% <ø> (ø)` | | | [contracts/consumer/virtual-staking/src/contract.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-Y29udHJhY3RzL2NvbnN1bWVyL3ZpcnR1YWwtc3Rha2luZy9zcmMvY29udHJhY3QucnM=) | `89.22% <0.00%> (ø)` | | | [packages/apis/src/local\_staking\_api.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-cGFja2FnZXMvYXBpcy9zcmMvbG9jYWxfc3Rha2luZ19hcGkucnM=) | `74.46% <0.00%> (ø)` | | | [packages/apis/src/vault\_api.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-cGFja2FnZXMvYXBpcy9zcmMvdmF1bHRfYXBpLnJz) | `89.65% <93.75%> (+17.24%)` | :arrow_up: | | [...provider/external-staking/src/test\_methods\_impl.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-Y29udHJhY3RzL3Byb3ZpZGVyL2V4dGVybmFsLXN0YWtpbmcvc3JjL3Rlc3RfbWV0aG9kc19pbXBsLnJz) | `83.33% <0.00%> (-1.18%)` | :arrow_down: | | [...acts/provider/native-staking-proxy/src/contract.rs](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs#diff-Y29udHJhY3RzL3Byb3ZpZGVyL25hdGl2ZS1zdGFraW5nLXByb3h5L3NyYy9jb250cmFjdC5ycw==) | `84.30% <87.50%> (-0.34%)` | :arrow_down: | | ... and [4 more](https://app.codecov.io/gh/osmosis-labs/mesh-security/pull/163?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=osmosis-labs) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.