fix: avoid hardcoding pool types

osmosis-labs / osmosis-frontend

Web interface for Osmosis Zone

https://app.osmosis.zone/

Apache License 2.0

230 stars 415 forks source link

fix: avoid hardcoding pool types #2833

Open p0mvn opened 7 months ago

p0mvn commented 7 months ago

Currently, we hardcode pool types as strings: https://github.com/osmosis-labs/osmosis-frontend/blob/71528ee78a8396561d070338c9a3462de82661fd/packages/web/server/queries/complex/pools/index.ts#L10-L17

Instead, these should be enum values imported from a single file rather than hardcoded in various locations

Acceptance Criteria

Pool types consolidated in a single file
Constans are imported everywhere else instead of being hardcoded

jonator commented 7 months ago

Long term, those should be the only place pool types are used. Once we have the prices query, and once the pool detail page is migrated to tRPC, we won't need the existing pools package and it and all other pools queries should be deleted.

MaxMillington commented 3 months ago

@p0mvn @jonator prices are migrated now right? Do we still need this issue?