search

osmosis-labs / osmosis-frontend

Web interface for Osmosis Zone
https://app.osmosis.zone/
Apache License 2.0
230 stars 416 forks source link

filter out bad pool per request from adam and johnny #3864

Closed MaxMillington closed 1 day ago

MaxMillington commented 1 day ago

What is the purpose of the change:

Filtering out pool 2159

Linear Task

https://linear.app/osmosis/issue/POL-1363/filter-out-pool-2159

Brief Changelog

Testing and Verifying

This change has been tested locally by rebuilding the website and verified content and links are expected

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 11:13pm
4 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **osmosis-frontend-datadog** | ⬜️ Ignored ([Inspect](https://vercel.com/osmo-labs/osmosis-frontend-datadog/FWwUTqJatKUy1p1g9AjdLX66mwLM)) | [Visit Preview](https://osmosis-frontend-datadog-git-filter-bad-pool-osmo-labs.vercel.app) | | Oct 2, 2024 11:13pm | | **osmosis-frontend-dev** | ⬜️ Ignored ([Inspect](https://vercel.com/osmo-labs/osmosis-frontend-dev/Cydh5Ejt5HFwp8zp6s11jpXgy5s7)) | [Visit Preview](https://osmosis-frontend-dev-git-filter-bad-pool-osmo-labs.vercel.app) | | Oct 2, 2024 11:13pm | | **osmosis-frontend-edgenet** | ⬜️ Ignored ([Inspect](https://vercel.com/osmo-labs/osmosis-frontend-edgenet/FH7HbzfQE4LaY7AMhBRKXZLLDkV2)) | | | Oct 2, 2024 11:13pm | | **osmosis-testnet** | ⬜️ Ignored ([Inspect](https://vercel.com/osmo-labs/osmosis-testnet/DNMgViRWCJXms5K7opCoeB8EcPky)) | [Visit Preview](https://osmosis-testnet-git-filter-bad-pool-osmo-labs.vercel.app) | | Oct 2, 2024 11:13pm |
coderabbitai[bot] commented 1 day ago

Walkthrough

The changes introduce a new constant FILTERABLE_IDS in both the pools-table.tsx and index.ts files. In pools-table.tsx, it contains the string element "2159" and is used to filter out pool items with matching IDs in the useMemo hook for poolsData. In index.ts, FILTERABLE_IDS is conditionally set based on the IS_TESTNET environment variable, either being an empty array or containing "2159", which is then used to filter pool results in the getPools function.

Changes

File Path Change Summary
packages/web/components/complex/pools-table.tsx Added a constant FILTERABLE_IDS with the value ["2159"] and updated filtering logic in useMemo for poolsData.
packages/server/src/queries/complex/pools/index.ts Added a constant FILTERABLE_IDS conditionally set based on IS_TESTNET, used to filter pools in getPools.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
jonator commented 1 day ago

I commented in slack, but I'm also no longer seeing the Cosmo pool in prod