Bug bash

[jonator]

Critical functional problems that must be fixed before refactor is merged. Please add a comment with checkboxes for each issue you find, and edit the comment if you find issues later.

[jonator]

• [x] Issues with next/images not loading (particularly OSMO & ATOM token images)
• [x] Token swap query params
  • [x] Sometimes don't get set on initial load (consider getStaticProps)
  • [x] Handle case of to and from being same token
• [x] @JeremyParish69 update config
  • [x] Add IntermediatePriceStore, place config in /config/price file
  • [x] Double check frontier version
• [x] Clear clipboard after trade
• [x] Show "success" toast after swap
• [x] Upgrade Keplr to fix Safari crash @Thunnini
• [x] Add depoolings table to assets page
• [x] Max withdraw IBC transfer setting is setting to 0
• [x] Button should be "Connect wallet" instead of "Swap" if wallet disconnected
• [x] Prices discrepancy (may be prices config difference)
• [ ] Connect wallet not working on non-Keplr mobile browsers (Safari)

[delivan]

• [ ] Amount is shrinking on trade clipboard whenever switching in and out
• [x] Clicking table header of liquidity in pools page does not change the sorting direction
• [x] On liquidity bonding dialog, the APRs aren't showed (when navigating directly to pool detail page)

[jonator]

Amount is shrinking on trade clipboard whenever switching in and out

This is what the original app does and I think it makes sense given that a fee is subtracted out. Otherwise the values being switched would have to be changed. If you agree then please strike out this checkbox item.

[JeremyParish69]

• [ ] Pool pages with Frontier assets still show '(channel-##)' (or maybe ibc/hash) instead of just the symbol, even when the coin information is available, but just not mentioned as a 'verified' asset.

• [x] Some pools' pages with Frontier assets shows an amount worth just the half/portion with non-Frontier assets. E.g., 547 ATOM/TICK. But it still shows an amount of tokens.

• [ ] Going to a specific pool page un-highlights the 'Pools' button in the navigation pane.

• [x] On a pool's page, the bonus bonding reward still shows even when there is 0 days remaining (gauge is finished, e.g., 602)

• [x] On Assets page, order is reversed? after osmo and ION, starts with DAI and ends on USDC. Sometimes it's inconsistent. I think it might be sorting where if there is a non-0 balance, then it is in the correct order, but all the tokens that don't have any balance are sorted in the opposite order.

• [x] Although I like that users can bond to pools without incentives (should there be a warning that there are no 'registered' incentives gauges? even though there could still be gauges?), there superfluid staking checkmark is visible and able to tick/untick. I feel like this should probably be greyed out (if not removed) for pools that don't have superfluid staking available.

  

• [x] Amount of assets in the pool probably should carry more decimal points (or something like 3 significant digits might work well because we don't need to show 18 decimal places for something with a lot of liquidity. There's a g-WBTC pool that shows 0 gWTBC even though there is liquidity. E.g., pool 694:

• [ ] All Withdraw/Deposit URL overrides show up as 'USDC' being the token (because it's listed first, perhaps?), even though the config file has the different tokens specified as the param in the URL. E.g., when I click Withdraw on (axelar) WETH, it still shows up as USDC on satellite because the URL has USDC as the param.

• [ ] Lost the ability to bond to arbitrary pools. This can be problematic for when a gauge has finished but some people have kept their liquidity bonded; they are given no way to remove it. Also makes it so that pools with new gauges (that are not yet registered) cannot be bonded to w/o CLI.

• [x] Lost the ability to bond to any pool, even those with gauges. No Liquidity Mining Label, No Start Earning button:

• [x] Some pools with gauges do not show any bonding gauge. E.g., 719, and 719 is XPRT/USDC, both of which are Main assets.

• [x] Withdrawing PSTAKE tries to withdraw OSMO. PSTAKE balance is not shown on Assets page and does not come up on Trade page. These could all be related to the same route cause??

• [ ] PSTAKE on Trade screen does not show the originating chain.

[jonator]

@JeremyParish69

Pool pages with Frontier assets still show '(channel-##)' (or maybe ibc/hash) instead of just the symbol, even when the coin information is available, but just not mentioned as a 'verified' asset.

I think this is related to the IBC registry. I'd try clearing cache then reloading (given that config has recently updated). If that doesn't fix LMK.

On Assets page, order is reversed? after osmo and ION, starts with DAI and ends on USDC. Sometimes it's inconsistent. I think it might be sorting where if there is a non-0 balance, then it is in the correct order, but all the tokens that don't have any balance are sorted in the opposite order.

Are you wanting to maintain config order for 0 balance assets?

[JeremyParish69]

@JeremyParish69

Pool pages with Frontier assets still show '(channel-##)' (or maybe ibc/hash) instead of just the symbol, even when the coin information is available, but just not mentioned as a 'verified' asset.

I think this is related to the IBC registry. I'd try clearing cache then reloading (given that config has recently updated). If that doesn't fix LMK.

I still see the same behaviour on multiple browsers after a hard refresh and clearing all cache and cookies.

On Assets page, order is reversed? after osmo and ION, starts with DAI and ends on USDC. Sometimes it's inconsistent. I think it might be sorting where if there is a non-0 balance, then it is in the correct order, but all the tokens that don't have any balance are sorted in the opposite order.

Are you wanting to maintain config order for 0 balance assets?

Yes, it should probably match the order in the config file.

[victortokaito]

• [x] Several users struggled with the "fuzzy" search library–it may be best to use just a direct search. Main issue: users were wondering why the other pools were coming up in unrelated search queries. For example, searching AKT places the "AKT pool" as # 4 after other less relevant pools (ATOM pools). Another user said "I probably don't understand how search works".

• [x] WBTC doesn't appear in the asset dropdown of the main trade page. As Jeremy mentioned, there's a WBTC pool that shows 0 WTBC even though there is liquidity (pool 694). During a user interview, user tried to swap for WBTC on main trading page, but WBTC cannot be chosen. However, WBTC does show up in the individual pool page's swap function. User assumed WBTC hasn't yet been added to the main frontend.

• [x] On mobile, the Osmosis logo sometimes obscures the hamburger menu. This prevents users from clicking on to the Pools and Assets pages. The actual experience may be different as we're testing with users on mobile browsers rather than Keplr itself. Keplr's window may affect the interface in other ways. Is there a way that we can test the in-app Keplr UI before having pushed the refactor @delivan?

[JeremyParish69]

• [ ] WBTC doesn't appear in the asset dropdown of the main trade page. As Jeremy mentioned, there's a g-WBTC pool that shows 0 gWTBC even though there is liquidity (pool 694). During a user interview, user tried to swap for WBTC on main trading page, but WBTC cannot be chosen. However, WBTC does show up in the individual pool page's swap function. User assumed WBTC hasn't yet been added to the main frontend.

Neither gWBTC nor axlWBTC has been added to Main, so it won't show up there. Edit: but axlWBTC should be, as it's been accepted in prop 229 and has incentives. I'll add it now. #534 I was thinking maybe for any Pool containing a Frontier asset, we could automatically redirect the user to the Frontier site and give them an opportunity to go back. The same could apply for Frontier assets that come up in the search--we indicate to the user that selecting that asset will bring them to the Frontier site. I'm not sure this can be addressed right away.

[jonator]

@victortokaito

Several users struggled with the "fuzzy" search library–it may be best to use just a direct search. Main issue: users were wondering why the other pools were coming up in unrelated search queries. For example, searching AKT places the "AKT pool" as # 4 after other less relevant pools (ATOM pools). Another user said "I probably don't understand how search works".

I fixed this. Good catch. The problem was that it was generating search results from input then sorting. The solution was to sort first then filter by search box.

I wanted to comment because I also enabled extended search for the search box. That lets users use advanced logic (and, or, exact match, prefix match, inverse match, etc.) in the search bar.

[jonator]

On mobile, the Osmosis logo sometimes obscures the hamburger menu. This prevents users from clicking on to the Pools and Assets pages. The actual experience may be different as we're testing with users on mobile browsers rather than Keplr itself. Keplr's window may affect the interface in other ways. Is there a way that we can test the in-app Keplr UI before having pushed the refactor @delivan?

How small is the screen width? I'm seeing no problems down to a screen size of <280px, which is much smaller than any popular mobile device.

[jonator]

Lost the ability to bond to arbitrary pools. This can be problematic for when a gauge has finished but some people have kept their liquidity bonded; they are given no way to remove it. Also makes it so that pools with new gauges (that are not yet registered) cannot be bonded to w/o CLI.

@JeremyParish69 Is this still happening? Yesterday I made changes to unbonding UI in pool detail page