search

osmosis-labs / osmosis-rust

Rust libraries for osmosis
Apache License 2.0
59 stars 52 forks source link

Run proto-build over latest version of osmosis #49

Closed georgemc98 closed 1 year ago

georgemc98 commented 1 year ago

Hello. This PR compiles the latest version of Osmosis @ commit 358eb2cf89ba5e0758a006d24920b98ca0b98808. We need it specifically for the two new pool queries merged in @ commit 94534da031b67a2eca6c24a98a266451130f41e5. Thank you for showing me the command to run the proto build @iboss-ptk

iboss-ptk commented 1 year ago

@georgemc98 Thank you! could you help run cargo clippy --fix few times til those Eq diffs are gone?

georgemc98 commented 1 year ago

@georgemc98 Thank you! could you help run cargo clippy --fix few times til those Eq diffs are gone?

Are there any other commands to run? I am not getting the same results when I run cargo clippy --fix. The Eqdiffs remain there

iboss-ptk commented 1 year ago

what I normally do is cd packages/osmosis-std then cargo clippy --fix --allow-dirty (without --allow-dirty you have to always commit). it needs to run few times before all the Eq diffs are gone since after fix, types that depends on the fixed types are now able to derive Eq, so it needs to repeat until it's all sorted out. If you find better way to handle this please let me know.

iboss-ptk commented 1 year ago

55 should fix the problem, no need for clippy fix anymore

georgemc98 commented 1 year ago

55 should fix the problem, no need for clippy fix anymore

Thanks, this PR should be good to go then. Quick question, do you know how to Serialize a struct to Proto type Any? I need to encode a Pool struct to an Any type in the QueryPoolResponse.

georgemc98 commented 1 year ago

55 should fix the problem, no need for clippy fix anymore

Thanks, this PR should be good to go then. Quick question, do you know how to Serialize a struct to Proto type Any? I need to encode a Pool struct to an Any type in the QueryPoolResponse. @iboss-ptk