search

osmosis-labs / osmosis

The AMM Laboratory
https://app.osmosis.zone
Apache License 2.0
890 stars 584 forks source link

Go module versioning #1709

Closed faddat closed 2 years ago

faddat commented 2 years ago

For reasons that I don't yet understand, we have moved the main branch back to v7.

This is making reviews and contributions a bit more complicated for me, and I just wanted to know why that was done

hleb-albau commented 2 years ago

can we use v9 for now?

faddat commented 2 years ago

@hleb-albau I don't know, that's actually the reason for this issue. Just seeking guidance on how to use the module version paths currently.

p0mvn commented 2 years ago

I think it's time to do this. Our main branch is still on v7. What do others think? I can create a PR today if we are good with this

ValarDragon commented 2 years ago

Sure, please go for it. If you have time, want to also add a manually triggerable github workflow to do the find/replace to update all imports? (And then we can just manually trigger that for open PRs for now)

p0mvn commented 2 years ago

Sounds good, on it

p0mvn commented 2 years ago

The manual workflow is now in. However, the rest of the CI does not auto-run from the pull request triggered by the workflow (example #2096). The reason is a Github security limitation, ref: https://github.com/peter-evans/create-pull-request/issues/48

One of the manual solutions is to close and reopen a PR (example #2101). There are more automatic solutions that are listed here: https://github.com/peter-evans/create-pull-request/issues/48

Unfortunately, the currently chosen Github Action does not support any suggested automatic solutions. We would either have to fork the existing action and modify it or switch to: https://github.com/peter-evans/create-pull-request

I think closing and reopening to trigger CI is fine for the time being. This workflow is not meant to be run regularly anyways (only on major releases).

I'm still open to changing the action if it proves to be troublesome