Closed p0mvn closed 2 years ago
Many recently added errors were defined in the balancer package. Instead, we might want to have them in types/errors.go for consistency.
types/errors.go
Move: https://github.com/osmosis-labs/osmosis/blob/3be2640a842394e962e323e9ad1885019e4e4229/x/gamm/pool-models/balancer/pool.go#L20-L27
to types/errors.go
Also, remove //nolint:deadcode and delete the unused errors
//nolint:deadcode
x/gamm/types/errors.go
I can do this
Thanks for taking all these
Background
Many recently added errors were defined in the balancer package. Instead, we might want to have them in
types/errors.go
for consistency.Suggested Design
Move: https://github.com/osmosis-labs/osmosis/blob/3be2640a842394e962e323e9ad1885019e4e4229/x/gamm/pool-models/balancer/pool.go#L20-L27
to
types/errors.go
Also, remove
//nolint:deadcode
and delete the unused errorsAcceptance Criteria
x/gamm/types/errors.go
//nolint:deadcode
is removed together with unused errors