osmosis-labs / osmosis

The AMM Laboratory
https://app.osmosis.zone
Apache License 2.0
889 stars 591 forks source link

refactor(x/gamm): move errors in balancer pool to `x/gamm/types/errors.go` #2034

Closed p0mvn closed 2 years ago

p0mvn commented 2 years ago

Background

Many recently added errors were defined in the balancer package. Instead, we might want to have them in types/errors.go for consistency.

Suggested Design

Move: https://github.com/osmosis-labs/osmosis/blob/3be2640a842394e962e323e9ad1885019e4e4229/x/gamm/pool-models/balancer/pool.go#L20-L27

to types/errors.go

Also, remove //nolint:deadcode and delete the unused errors

Acceptance Criteria

stackman27 commented 2 years ago

I can do this

p0mvn commented 2 years ago

Thanks for taking all these