osmosis-labs / osmosis

The AMM Laboratory
https://app.osmosis.zone
Apache License 2.0
885 stars 580 forks source link

[VS Incentives]: Revisit decision to export `SetVolume` for testing purposes #6400

Open AlpinYukseloglu opened 1 year ago

AlpinYukseloglu commented 1 year ago

Background

For the sake of simplifying volume split incentive testing, setVolume was exported as a public keeper method in #6366. While this allowed us to avoid significant amounts of confusing test setup, exporting internal functions for testing purposes feels like code smell that should be revisited once the feature is complete.

Suggested Design

Acceptance Criteria

p0mvn commented 11 months ago

I think we are so deep into relying on this helper everywhere now, making the refactor be not worthwhile in terms of time