osmosis-labs / osmosis

The AMM Laboratory
https://app.osmosis.zone
Apache License 2.0
889 stars 592 forks source link

Add Uptime Accumulator between 1 minute and 1 hour #7985

Open JohnnyWyles opened 7 months ago

JohnnyWyles commented 7 months ago

Background

Current Uptime Incentive accumulators used are time.Nanosecond time.Minute time.Hour time.Hour * 24 time.Hour * 24 * 7 time.Hour * 24 * 7 * 2

Early usage has suggested that 1 minute has a minor impact on the width of liquidity, and 1 hour is often too long for new pools with the current frontend design as forfeited incentives are not visible.

Conversely, longer periods are not used as frequently - the one 14 day uptime in use expires 3rd May, all others use 1 min, 1 hour or 1 day.

Suggested Design

Suggesting the addition of a new accumulator between 1 minute and 1 hour Either 5 min or 15 min. Ideally another accumulator between 1 hour and 1 day (6 hours) would be available too, however I understand that additional accumulators are resource intensive.

This could be offset by removing 7 and 14 day Uptimes.

We need logic in uptime handler,

Acceptance Criteria

New uptimes able to be set/approved by governance to be set Existing incentives not broken (This may require a gov prop to remove new 7 and 14 uptimes if required)

ValarDragon commented 7 months ago

Thanks for making this issue. I am in support of adding a new 15 minute one.