Closed tongjicoder closed 3 weeks ago
In the app/apptesting
package, the function names for creating concentrated liquidity (CL) pools have been updated for better clarity and consistency. The functions createConcentratedPoolsFromCoinsWithSpreadFactor
and createConcentratedPoolsFromCoins
are now renamed to CreateConcentratedPoolsAndFullRangePositionWithSpreadFactor
and CreateConcentratedPoolsAndFullRangePosition
, respectively, reflecting their purpose more accurately.
File Path | Change Summary |
---|---|
app/apptesting/concentrated_liquidity.go |
createConcentratedPoolsFromCoinsWithSpreadFactor renamed to CreateConcentratedPoolsAndFullRangePositionWithSpreadFactor . |
createConcentratedPoolsFromCoins renamed to CreateConcentratedPoolsAndFullRangePosition . |
In code, we marked a change so neat,
Old names swapped for ones replete.
Pools and positions, full and wide,
With spread factors now clarified.
Oh code's delight, it’s crystal clear,
A rabbit’s cheer, let’s spread good cheer! 🐇✨
app/apptesting/concentrated_liquidity.go (2)
`820-820`: Ensure the function comment accurately reflects the updated function name and its functionality. This change aligns the function comment with the new, more descriptive function name, enhancing code readability and maintainability. --- `839-839`: Ensure the function comment accurately reflects the updated function name and its functionality. This change improves clarity by ensuring the function comment matches the new function name, which is more descriptive of the function's purpose.
Important note to contributors: We deeply value your contributions. However, due to a large influx of airdrop hunters, we are currently unable to accept small lint changes from first-time contributors. We encourage you to look for issues that offer more substantial contributions to the project or issues from the good first issue label. This helps us maintain the quality and integrity of the codebase, and provides a more meaningful experience for you as a contributor.
make function comment match function names
What is the purpose of the change
make function comment match function names
(E.g.: This pull request improves documentation of area A by adding ....
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)