coderabbitai[bot]
commented
3 months ago Walkthrough
The recent updates focus on optimizing the IBCModule in ibc_module.go by altering the behavior of the OnAcknowledgementPacket function, which now returns nil instead of invoking im.app.OnAcknowledgementPacket under specific conditions. Additionally, an unnecessary IBC acknowledgements time has been removed from CheckTx/RecheckTx, as noted in the v25.1.2 release of the CHANGELOG.md.
Changes
| File | Change Summary |
|---|---|
x/ibc-rate-limit/ibc_module.go |
Altered OnAcknowledgementPacket to return nil under certain conditions instead of calling another function |
CHANGELOG.md |
Added note about removing unnecessary IBC acknowledgements time from CheckTx/RecheckTx in v25.1.2 |
Poem
Amidst the code, where packets roam,
Acknowledgements now find their home.
In CheckTx, time we save,
For efficiency, changes we gave.
With subtle tweaks and lines anew,
Our swift module, proud and true! 🐇📜
Recent review details
**Configuration used: CodeRabbit UI** **Review profile: CHILL**Commits
Files that changed from the base of the PR and between f121350054d8340e53461417ae9120b17c07cef8 and 9f558736b1389cd19112b48ccf7fba01b25812e7.Files selected for processing (1)
* CHANGELOG.md (1 hunks)Additional context used
Markdownlint
CHANGELOG.md
1089-1089: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 1101-1101: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 1110-1110: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 1115-1115: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 1167-1167: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 428-428: Punctuation: '.' (MD026, no-trailing-punctuation) Trailing punctuation in heading --- 691-691: null (MD034, no-bare-urls) Bare URL used --- 749-749: null (MD034, no-bare-urls) Bare URL used --- 1330-1330: null (MD042, no-empty-links) No empty links
Additional comments not posted (1)
CHANGELOG.md (1)
`55-56`: The update in the changelog for removing IBC acknowledgements is clear and concise.
Please note that this is generally, not the best solution, but all we risk is wasted compute getting on-chain at the trade-off of better mempools.
I have whitebox examined, that for Acknowledgement we are gaining nothing. This is running all of PFM's logic and all of the main IBC-go logic. This is not needed for the redundant relay goal.