search

osmosis-labs / osmosis

The AMM Laboratory
https://app.osmosis.zone
Apache License 2.0
875 stars 562 forks source link

chore: bump ibc-go from v8.2.1 to v8.3.1 #8428

Closed czarcas7ic closed 1 week ago

czarcas7ic commented 1 week ago

Closes: #XXX

What is the purpose of the change

Since we are using comet 0.38.x branch it makes sense to use v8.3.x line of ibc go rather than v8.2.x

github-actions[bot] commented 1 week ago

Important Notice

This PR modifies an in-repo Go module. It is one of:

The dependent Go modules, especially the root one, will have to be updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

coderabbitai[bot] commented 1 week ago

Walkthrough

The recent update enhances the InitNormalKeepers function in the AppKeepers struct. This involves adding a call to icaHostKeeper.WithQueryRouter(bApp.GRPCQueryRouter()), injecting the gRPC query router into the ICA Host Keeper. This change ensures better integration and functionality of the Interchain Accounts (ICA) Host within the application's greater architecture.

Changes

Files Change Summary
app/keepers/keepers.go Updated InitNormalKeepers to include icaHostKeeper.WithQueryRouter(bApp.GRPCQueryRouter()), improving ICA Host integration.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant GRPCQueryRouter
    participant bApp
    participant AppKeepers
    participant icaHostKeeper

    Client->>bApp: Initialize Application
    bApp->>AppKeepers: InitNormalKeepers(...)
    AppKeepers->>icaHostKeeper: WithQueryRouter(bApp.GRPCQueryRouter())
    icaHostKeeper->>GRPCQueryRouter: Register Query Router
    GRPCQueryRouter-->>icaHostKeeper: Query Router Integrated
    icaHostKeeper-->>AppKeepers: Initialization Complete
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 399ed2bcb4717e3a84116d7c32096ef3e4f93a07 and ab5be3f8178daebfa2818f869309ff9b68b3f699.
Files ignored due to path filters (8) * `go.mod` is excluded by `!**/*.mod` * `go.sum` is excluded by `!**/*.sum`, `!**/*.sum` * `osmoutils/go.mod` is excluded by `!**/*.mod` * `osmoutils/go.sum` is excluded by `!**/*.sum`, `!**/*.sum` * `x/epochs/go.mod` is excluded by `!**/*.mod` * `x/epochs/go.sum` is excluded by `!**/*.sum`, `!**/*.sum` * `x/ibc-hooks/go.mod` is excluded by `!**/*.mod` * `x/ibc-hooks/go.sum` is excluded by `!**/*.sum`, `!**/*.sum`
Files selected for processing (1) * app/keepers/keepers.go (1 hunks)
Additional comments not posted (2)
app/keepers/keepers.go (2)
`343-343`: **Ensure proper integration of `icaHostKeeper.WithQueryRouter` method call.** The addition of `icaHostKeeper.WithQueryRouter(bApp.GRPCQueryRouter())` integrates the `icaHostKeeper` with the gRPC query router of `bApp`. This is crucial for enabling query routing functionalities for the interchain accounts host module. Ensure that this integration does not interfere with existing functionalities and that it aligns with the intended architectural changes.
Verification successful --- **Ensure proper integration of `icaHostKeeper.WithQueryRouter` method call.** The integration of `icaHostKeeper` with the gRPC query router appears to be correctly implemented without affecting existing functionalities. The initialization, configuration, and assignment of `icaHostKeeper` are consistent and do not show any unintended side effects. - Initialization: `icaHostKeeper := icahostkeeper.NewKeeper(...)` - Configuration: `icaHostKeeper.WithQueryRouter(bApp.GRPCQueryRouter())` - Assignment: `appKeepers.ICAHostKeeper = &icaHostKeeper`
Scripts executed The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Description: Verify that the integration does not affect existing functionalities. # Test: Search for usage of `icaHostKeeper` and related configurations. rg --type go $'icaHostKeeper' ``` Length of output: 238 --- --- Script: ```shell #!/bin/bash # Description: Verify the initialization and configuration of icaHostKeeper and its impact on the system. # Test: Search for initialization of icaHostKeeper. rg --type go 'icahostkeeper.NewKeeper' # Test: Search for assignment to appKeepers.ICAHostKeeper. rg --type go 'appKeepers.ICAHostKeeper' # Test: Search for other usages of icaHostKeeper. rg --type go 'icaHostKeeper' ``` Length of output: 537
--- `340-345`: **Check the placement and context of the new method call.** The method `icaHostKeeper.WithQueryRouter(bApp.GRPCQueryRouter())` is placed within the `InitNormalKeepers` function. It's important to ensure that this method is called at the right point in the lifecycle of `icaHostKeeper` initialization. Verify that the query router is available and fully configured at this point in the execution.
Verification successful ### Actions: 1. Search for the definition and initialization of `bApp.GRPCQueryRouter()` to verify its configuration status before being passed to `icaHostKeeper`. --- ### Actions: 1. Search for the initialization of `GRPCQueryRouter` within `app/app.go` to confirm its setup. --- ### Actions: 1. Check the function call order to ensure `OsmosisApp` setup is completed before `InitNormalKeepers`. --- **Initialization Order Verified** The `bApp.GRPCQueryRouter()` is properly initialized within the `OsmosisApp` setup process and is configured before being used in the `InitNormalKeepers` function. The initialization sequence in `app/app.go` confirms that the `GRPCQueryRouter` is set up as part of the application configuration, ensuring it is available and fully configured before being passed to `icaHostKeeper`. - `app/app.go`: Initialization of `GRPCQueryRouter` occurs during the setup of `OsmosisApp`. - `app/keepers/keepers.go`: The `InitNormalKeepers` function, which includes the call to `icaHostKeeper.WithQueryRouter(bApp.GRPCQueryRouter())`, is called after the `OsmosisApp` setup is complete.
Scripts executed The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Description: Ensure the query router is available and configured before being passed to `icaHostKeeper`. # Test: Check the initialization order and configuration of `bApp.GRPCQueryRouter()`. rg --type go $'bApp.GRPCQueryRouter()' ``` Length of output: 385 --- --- Script: ```shell #!/bin/bash # Find the definition and initialization of `bApp.GRPCQueryRouter()` rg --type go 'GRPCQueryRouter' --context 5 ``` Length of output: 10189 --- --- Script: ```shell #!/bin/bash # Find the exact initialization point of `GRPCQueryRouter` within `app/app.go` rg --type go 'GRPCQueryRouter' app/app.go --context 10 ``` Length of output: 3393 --- --- Script: ```shell #!/bin/bash # Verify the order of function calls to ensure `OsmosisApp` setup is completed before `InitNormalKeepers`. rg --type go 'InitNormalKeepers' --context 20 ``` Length of output: 8766
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.