search

osmosis-labs / osmosis

The AMM Laboratory
https://app.osmosis.zone
Apache License 2.0
887 stars 580 forks source link

feat: Generate default indexer configs on osmosisd init #8436

Closed cryptomatictrader closed 3 months ago

cryptomatictrader commented 3 months ago

With this PR, on "osmosisd init", config group for indexer "osmosis-indexer" and its default, corresponding attributes will be added to app.toml

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent updates to the osmosis project include fixing a bug in reading the osmosis-sqs value in the osmosis-indexer configuration, along with the addition of a default indexer configuration in the osmosisd init command. These changes also involve including new import statements and adding an IndexerConfig field in the CustomAppConfig struct, enabling the integration of Osmosis Indexer settings within the configuration template.

Changes

File Change Summary
CHANGELOG.md Added bug fix for osmosis-sqs value reading in osmosis-indexer config and indexer config addition on osmosisd init.
cmd/osmosisd/cmd/root.go Added import for indexer, included IndexerConfig field in CustomAppConfig, and updated the configuration template for Osmosis Indexer settings.
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 725afda32ab0f24de740f42eea30d41b411673de and 1bdc9eff2fd32e62a7a8a0c03620d2a4364c7639.
Files selected for processing (2) * CHANGELOG.md (1 hunks) * cmd/osmosisd/cmd/root.go (4 hunks)
Additional context used
Markdownlint
CHANGELOG.md
1094-1094: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 1106-1106: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 1115-1115: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 1120-1120: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 1172-1172: Expected: h3; Actual: h4 (MD001, heading-increment) Heading levels should only increment by one level at a time --- 433-433: Punctuation: '.' (MD026, no-trailing-punctuation) Trailing punctuation in heading --- 696-696: null (MD034, no-bare-urls) Bare URL used --- 754-754: null (MD034, no-bare-urls) Bare URL used --- 1335-1335: null (MD042, no-empty-links) No empty links
Additional comments not posted (2)
cmd/osmosisd/cmd/root.go (2)
`31-31`: **Import statement added for indexer package.** This change aligns with the PR's objective to integrate the indexer during the osmosisd initialization process. Ensure that the versioning (`v25`) matches the project's current requirements and dependencies. --- `639-640`: **Addition of `IndexerConfig` to `CustomAppConfig`.** This addition is crucial for enabling the indexer functionality within the application. It's important to ensure that the `IndexerConfig` is properly utilized throughout the application, especially in functions that initialize or configure the application.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.