Closed alessandrolomanto closed 2 weeks ago
The new addition of .github/workflows/pprof-auto.yml
introduces a GitHub Actions workflow that automatically handles pprof automation upon the creation of new tags in the repository. This setup ensures that pprof processes are triggered and configured correctly whenever a new tag is pushed, streamlining performance profiling and automation activities within the project.
File | Change Summary |
---|---|
.github/workflows/pprof-auto.yml | Introduces a GitHub Actions workflow for pprof automation triggered by new tag creation. |
sequenceDiagram
participant Developer
participant GitHub
participant Workflow Runner
Developer->>GitHub: Push new tag
GitHub->>Workflow Runner: Trigger pprof-auto.yml workflow
Workflow Runner->>Workflow Runner: Set up workflow environment
Workflow Runner->>Workflow Runner: Dispatch custom event for pprof automation
Workflow Runner->>Workflow Runner: Execute pprof automation tasks
.github/workflows/pprof-auto.yml (5)
`1-2`: **LGTM!** The comment is clear and provides a good overview of the workflow's purpose. --- `3-4`: **LGTM!** The workflow name is descriptive and aligns well with its purpose. --- `5-10`: **LGTM!** The configuration correctly sets the workflow to trigger on any new tag push. --- `11-19`: **LGTM!** The job and runner configuration is appropriate and follows standard practices. --- `20-39`: **LGTM! But verify the necessity of empty strings for `osmosis_sdk_fork_hash` and `osmosis_comet_fork_hash`.** The repository dispatch step is well-defined and the parameters in the `client-payload` are comprehensive. However, ensure that the empty strings for `osmosis_sdk_fork_hash` and `osmosis_comet_fork_hash` are intentional and necessary.
Closes: PLAT-258
What is the purpose of the change
This pull request introduces a new GitHub Actions workflow to automate the triggering of pprof profiling automation upon the creation of a new tag. The workflow uses the
peter-evans/repository-dispatch
action to send a dispatch event with relevant details, such as commit SHA, tag name, and profiling parameters, to the target repository.Required Secrets: