Closed p0mvn closed 3 months ago
[!WARNING]
Rate limit exceeded
@p0mvn has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 56 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 5595e657afb88d94a3c07415ec49fdc23a1a0912 and 0f6ec9672005a52ed0523a1b6b0fb6d8360e3076.
The changes mainly focus on refactoring and enhancing the initialization and processing flow within the Osmosis app. The ColdStartManager
is replaced with BlockProcessStrategyManager
, a PoolTracker
is introduced, and new keepers related to pools and other modules are added. There are also updates to various interfaces, configurations, and the addition of new methods for publishing pair data through the PubSubClient.
Files | Change Summary |
---|---|
app/app.go |
Significant modifications to the NewOsmosisApp function: replaced ColdStartManager with BlockProcessStrategyManager , introduced PoolTracker , and added new keepers. Updated function signatures to accommodate these changes. |
cmd/osmosisd/cmd/root.go |
Added pair-topic-id declaration for configuration settings. |
ingest/indexer/domain/keepers.go |
Added PoolManagerKeeper field and GetTradingPairTakerFee method in the Keepers struct and interface. |
ingest/indexer/domain/mocks/publisher_mock.go |
Introduced PublisherMock struct implementing the domain.Publisher interface with unimplemented methods. |
ingest/indexer/domain/pair.go |
Added additional fields for pair metadata in the Pair struct. |
ingest/indexer/domain/pool.go |
Restructured imports in pool.go for better organization. |
ingest/indexer/domain/publisher.go |
Added PublishPair method to the Publisher interface and defined a new PairPublisher interface. |
ingest/indexer/domain/errors.go |
Renamed error variable from ErrColdStartManagerDidNotIngest to ErrDidNotIngestAllData . |
ingest/indexer/indexer_config.go |
Added PairTopicID field to the Config struct and updated NewConfigFromOptions . |
ingest/indexer/publisher.go |
Implemented PublishPair method in indexerPublisher struct. |
ingest/indexer/service/blockprocessor/block_process_indexer_factory.go |
Introduced NewBlockProcessor function for creating a block process strategy. |
ingest/indexer/service/blockprocessor/block_updates_indexer_block_process_strategy.go |
Introduced a block processing strategy for indexing block updates. |
ingest/indexer/service/blockprocessor/full_indexer_block_process_strategy.go |
Introduced fullIndexerBlockProcessStrategy for processing block updates. |
ingest/indexer/service/blockprocessor/pair_publisher.go |
Introduced a PairPublisher type for publishing denom pairs. |
ingest/indexer/service/client/pubsub_client.go |
Added pairTopicId field, updated NewPubSubClient function signature, and added PublishPair method to publish pairs. |
ingest/indexer/service/writelistener/bank_write_listener.go |
Updated naming and logic to replace coldStartManager with blockProcessStrategyManager . |
ingest/indexer/service/writelistener/bank_write_listener_test.go |
Renamed and updated related function calls from coldStartManager to blockProcessStrategyManager . |
ingest/sqs/service/blockprocessor/block_updates_sqs_block_process_strategy_test.go |
Modified validateTransformAndLoadFuncMock function. |
ingest/sqs/service/blockprocessor/full_sqs_block_process_strategy_test.go |
Modified validateTransformAndLoadFuncMock function call. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Closes: #XXX
What is the purpose of the change
Please read this Slack thread for a detailed explanation of the work accomplished here: https://osmosis-network.slack.com/archives/C060VCJAVBL/p1720223177058649
Relevant indexer PR: https://github.com/osmosis-labs/indexer/pull/9
Testing
/pair
flow end-to-end/pair
design is set in stone