fix: add cosmos.msg.v1.service to message services

mattverse commented 1 week ago

Closes: #XXX

What is the purpose of the change

Taking over PR https://github.com/osmosis-labs/osmosis/pull/8689

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request includes updates to the CHANGELOG.md file, detailing changes related to state breaking, state compatible, and state machine breaking categories. Additionally, it introduces a new option to the Msg service in multiple proto files, indicating that these services are now recognized as Cosmos message services. The changes primarily enhance the integration of various services with the Cosmos messaging framework without altering existing functionalities or message structures.

Changes

File Path	Change Summary
`CHANGELOG.md`	Updated with new entries for state breaking, state compatible, and state machine breaking changes.
`proto/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/gamm/poolmodels/balancer/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/gamm/poolmodels/stableswap/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/gamm/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/ibchooks/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/incentives/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/lockup/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/poolmanager/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/protorev/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/smartaccount/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/superfluid/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/tokenfactory/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/txfees/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.
`proto/osmosis/valsetpref/v1beta1/tx.proto`	Added service option `option (cosmos.msg.v1.service) = true;` to `Msg` service.

Possibly related PRs

#8310: Introduces a new feature related to taker fee share, relevant to the messaging framework changes.
#8423: Includes updates to the CHANGELOG.md, directly related to the entries made in this PR.
#8563: Adds additional queries in the x/gauges module, aligning with updates in state machine breaking and state compatible categories.
#8754: Addresses missing proto files for indexing, relevant to state compatible changes documented in this PR.
#8779: Includes a changelog entry for the bump of cometbft/cosmos-sdk versions, directly related to version updates in this PR.
#8807: Updates the cometbft version and includes changelog entries reflecting similar updates in this PR.
#8822: Updates the changelog for the v27.0.0 release, which is directly related to the main PR's updates to the changelog and the documentation of notable changes.

Suggested labels

C:docs, V:state/breaking, A:no-changelog

Suggested reviewers

czarcas7ic
nicolaslara
p0mvn

📜 Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

📥 Commits

Reviewing files that changed from the base of the PR and between fa01dd4e0c369b106107b96cf455cbf1a05a8525 and 8b4fcd901ee57c7af12d09618b90b092242e4a4e.

📒 Files selected for processing (1)

* `CHANGELOG.md` (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

* CHANGELOG.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 1 week ago

Important Notice

This PR modifies an in-repo Go module. It is one of:

osmomath
osmoutils
x/ibc-hooks
x/epochs

The dependent Go modules, especially the root one, will have to be updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
Provide the current branch name
On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

osmosis-labs / osmosis