search

osmosis-labs / osmosis

The AMM Laboratory
https://app.osmosis.zone
Apache License 2.0
893 stars 595 forks source link

chore(deps): bump cloud.google.com/go/pubsub from 1.44.0 to 1.45.1 #8829

Closed mattverse closed 21 hours ago

mattverse commented 1 week ago

Closes: #XXX

What is the purpose of the change

Bumps cloud.google.com/go/pubsub from 1.44.0 to 1.45.1.

Testing and Verifying

Documentation and Release Note

Where is the change documented?

coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request implements changes primarily focused on enhancing error handling across multiple methods in the balancer, stableswap, and lockup modules. The modifications replace the use of fmt.Sprintf for error message formatting with more direct approaches, improving clarity and readability. Additionally, descriptive error messages have been added to various methods, ensuring that error reporting is more informative without altering the existing functionality or control flow of the methods.

Changes

File Path Change Summary
x/gamm/pool-models/balancer/pool.go Improved error handling in getPoolAssetAndIndex by replacing fmt.Sprintf with errorsmod.Wrapf.
x/gamm/pool-models/stableswap/pool.go Simplified error message formatting in CalcOutAmtGivenIn and updated error handling in CalcInAmtGivenOut.
x/lockup/keeper/lock.go Enhanced error wrapping in AddToExistingLock to provide more context on token addition failures.
x/lockup/keeper/msg_server.go Updated error handling in ExtendLockup and ForceUnlock methods with clearer messages and response flags.
tests/e2e/configurer/chain/commands.go Changed logging format in InstantiateWasmContract and WasmExecute methods for improved clarity.
tests/e2e/containers/containers.go Simplified logging in ExecCmd method by removing unnecessary fmt.Sprintf.
x/txfees/keeper/feedecorator.go Enhanced error messages in DeductFees for insufficient funds to provide clearer feedback.

Possibly related PRs

Suggested labels

A:backport/v27.x

Suggested reviewers

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."
📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 045919b0fabea3d7553986c928cde19542c8a359 and d8182ca06f5e61c95466787105c7c3047ab3dc7b.
📒 Files selected for processing (3) * `tests/e2e/configurer/chain/commands.go` (2 hunks) * `tests/e2e/containers/containers.go` (1 hunks) * `x/txfees/keeper/feedecorator.go` (1 hunks)
✅ Files skipped from review due to trivial changes (2) * tests/e2e/configurer/chain/commands.go * tests/e2e/containers/containers.go
🔇 Additional comments (2)
x/txfees/keeper/feedecorator.go (2) `339-340`: **LGTM: Improved error handling for insufficient base denom funds** The error wrapping enhancement provides better context by including the underlying error details while maintaining the correct error type. --- `345-346`: **LGTM: Consistent error handling for non-base denom funds** The error handling enhancement maintains consistency with the base denom case and provides better debugging context.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 3 days ago

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!