search

osmosis-labs / test-tube

Test tube for cosmos-sdk chains integration test, written in Rust!
Apache License 2.0
53 stars 31 forks source link

Remove cosmrs from osmosis-test-tube and only relying osmosis-std types #25

Open iboss-ptk opened 1 year ago

iboss-ptk commented 1 year ago

Reason being, cosmrs types don't derive serde and osmosis-std now have ability to generate types from cosmos module.

potential blocker: https://github.com/osmosis-labs/osmosis-rust/issues/52

Problem

  • osmosis-std struct requires implementing Serialize & Deserialize but tendermint_proto's structs do not implement them, so whenever there is a struct that depends on tendermint_proto, it will cause compile errors
    • it maps tendermint related struct to tendermint_proto by this line
  • This hack is used to skip struct that depends on tendermint_proto to suppress compiles error.

So that maybe not all of them can be replaced at the moment, only case by case, unless the blocker is resolved.