search

osnr / TabFS

🗄 Mount your browser tabs as a filesystem.
https://omar.website/tabfs/
GNU General Public License v3.0
3.82k stars 106 forks source link

Set UID/GID #42

Open AstraLuma opened 3 years ago

AstraLuma commented 3 years ago

Using this on a managed Mac, 10.15.7, using osxfuse from homebrew.

Currently, virtual files are created under root:wheel, with only root having write permissions. This makes it annoying to actually poke at it.

Please create the files with their UID/GID set, so the user can actually use them.

AstraLuma commented 3 years ago

I added this to tabfs_getattr() and it seemed to do it:

    stbuf->st_uid = getuid();
    stbuf->st_gid = getgid();
osnr commented 3 years ago

Thanks for the report. I'm not familiar with "managed Mac" -- does that imply that there are extra restrictions on file access that require UID/GID to be set?

My understanding was that FUSE doesn't normally enforce permissions and just has a blanket policy that the user running the filesystem can (exclusively) access it, although I don't have a reference for this off the top of my head. I could be wrong here / am happy to implement this if it's useful.

AstraLuma commented 3 years ago

I mean, It's a work laptop that IT has hooks on.

Yes, this patch for me took the mount from "usable only by root" to "usable by the user". But I also had to undo some of the osxfuse name stuff.