search

osociety / network_tools

Networking Tools library which can help you discover open ports, devices on subnet and many other things.
https://pub.dev/packages/network_tools
BSD 3-Clause "New" or "Revised" License
45 stars 13 forks source link

Finding more ip of mdns #165

Closed guyluz11 closed 11 months ago

guyluz11 commented 11 months ago

Mdns search can now find more reliably IPs of devices. Mdns search now includes results of ipv6 devices as well.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (a34ca22) 77.08% compared to head (5bf1166) 74.94%.

Files Patch % Lines
lib/src/mdns_scanner/mdns_scanner.dart 4.16% 23 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #165 +/- ## ========================================== - Coverage 77.08% 74.94% -2.14% ========================================== Files 19 19 Lines 480 491 +11 ========================================== - Hits 370 368 -2 - Misses 110 123 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

git-elliot commented 11 months ago

@guyluz11 would merging this close https://github.com/osociety/network_tools/issues/164?

guyluz11 commented 11 months ago

@guyluz11 would merging this close #164?

Nope This PR contains similar function but not the exact one. This PR have function to find IP from mdns name and serviceType and the issue is for finding ip from only mdns name.