search

osociety / network_tools

Networking Tools library which can help you discover open ports, devices on subnet and many other things.
https://pub.dev/packages/network_tools
BSD 3-Clause "New" or "Revised" License
42 stars 13 forks source link

Logger renaming and bug fix #188

Closed git-elliot closed 6 months ago

git-elliot commented 6 months ago
  1. Since log is a method defined in math.dart, so I am renaming log instance to logger.
  2. Type casting for hostIds passed as string.
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 82.09%. Comparing base (b43f2e9) to head (79a8e69). Report is 9 commits behind head on dev.

Files Patch % Lines
...dns_scanner/get_srv_list_by_os/srv_list_linux.dart 40.00% 3 Missing :warning:
.../src/services/impls/host_scanner_service_impl.dart 85.71% 1 Missing :warning:
.../src/services/impls/mdns_scanner_service_impl.dart 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #188 +/- ## ========================================== + Coverage 75.53% 82.09% +6.56% ========================================== Files 23 23 Lines 564 564 ========================================== + Hits 426 463 +37 + Misses 138 101 -37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.