osociety / network_tools

Networking Tools library which can help you discover open ports, devices on subnet and many other things.

https://pub.dev/packages/network_tools

BSD 3-Clause "New" or "Revised" License

45 stars 13 forks source link

Fix issue #40 and #3 #41

Closed guyluz11 closed 2 years ago

guyluz11 commented 2 years ago

40

3

guyluz11 commented 2 years ago

Not sure why all the old commits got here but most of it is stuff that got merged before.

Accidentally wrote in one commit fix for # 3. It was suppose to be Fix for # 40.

guyluz11 commented 2 years ago

I have added fox for #3 as well.

git-elliot commented 2 years ago

Not sure why all the old commits got here

Because we haven't merged dev into main, maybe that's why it's showing all the previous commits.

guyluz11 commented 2 years ago

Not sure why all the old commits got here

Because we haven't merged dev into main, maybe that's why it's showing all the previous commits.

This pr is to dev branch so probably it is other reason.

git-elliot commented 2 years ago

Seems like this by design, but have some workaround. Although no harm, let it be like this. Source - GitHub pull request showing commits that are already in target branch

guyluz11 commented 2 years ago

I've added another feature here so I should also update the version and the change log. You can check everything else in the meantime.