`HostScanner.discover` should run inside an isolate by default

osociety / network_tools

Networking Tools library which can help you discover open ports, devices on subnet and many other things.

https://pub.dev/packages/network_tools

BSD 3-Clause "New" or "Revised" License

45 stars 13 forks source link

`HostScanner.discover` should run inside an isolate by default #42

Closed ivirtex closed 1 year ago

ivirtex commented 2 years ago

Since HostScanner.discover runs on the main thread, the whole UI freezes until host discovery finishes. This means more work for the developers und unnecessary confusion. Putting the whole process inside an isolate would unblock app interaction.

git-elliot commented 2 years ago

Isn't it possible to run the required methods inside compute() from flutter's foundation library.

ivirtex commented 2 years ago

I don't think so, it is possible when working with futures, but not streams.

guyluz11 commented 1 year ago

Maybe we can close the issue now, @ivirtex can you test it ?

ivirtex commented 1 year ago

Yeah, great job!