Closed nickcernis closed 6 years ago
Initial version done. I'll fix some additional coding standards and await theme test results before sending a PR.
phpcs now passing for all files:
Now awaiting plugin testing before PR and merge.
@nickcernis I'm starting to test so I'll leave a checklist here for any issues and edit.
entry-header
to header
: <header class="portfolio-header entry-header">
Thanks, @dreamwhisper. I've reverted to entry-header over portfolio-header, so it will now be: <header class="entry-header">
. (context
can't take an array of two values, and the class comes from the context). If you need portfolio-header
too, though, let me know.
Please feel free to add to the above should you find anything more.
Ah, yeah, a filter would work, but it really isn't necessary with the widget classes. problem solved :) will continue testing.
I'm using the Genesis Portfolio Pro plugin, vers. 1.1. on my portfolio page. But where can I find the actual widget like nickcernis displays above? I can't find it!
@KerriMarvel The widget is in development and will be released as part of Portfolio Pro 1.2.
For testing:
Test in feature/portfolio-widget branch.
Add a portfolio widget to any widget area.
@nickcernis Confirmed +1
Environment:
WordPress: Version: 4.9.8
PHP: Versions: 5.6.24 & 7.1.14
Genesis Framework: Version: 2.6.1
Active Themes: Genesis Sample - Version: 2.6.0 Essence Pro - Version: 1.0.2
Branch: https://github.com/studiopress/genesis-portfolio-pro/tree/feature/portfolio-widget
Results:
(couldn't find any error in HTML or structured data)
Thanks so much for your help testing these, @Ali-RMD!
Here is some honest negative feedback to the development of this plugin. Consider that many developers, who build their sites on the Genesis framework, are not interested in hacking a plugin to get it to work with their projects the way they need it to, especially one that functions as a custom post type. For instance, attempting to create an archive-portfolio template, to allow more granular functionality, is rendered moot by this plugin and throws all conventional Genesis hooks out the window. The whole point of developing with Genesis is control and customization and understanding the code behind it. If people want an idiot proof portfolio based theme they might as well head over to Themeforest and buy one there. Building a plugin with only partial features doesn't reflect what Genesis developers expect from StudioPress, all we have to do is remember Simple Hooks and Simple Edits to understand what a Genesis plugin is supposed to be. Unfortunately, IMHO, Genesis Portfolio Pro is neither useful as a portfolio option and definitely is not worth using as a pro.
Thanks for your feedback, @danbo321.
…attempting to create an archive-portfolio template, to allow more granular functionality, is rendered moot by this plugin and throws all conventional Genesis hooks out the window.
You can create an archive-portfolio.php
template in your child theme and still use regular Genesis hooks. We do this in the Minimum Pro StudioPress theme for the layout on the portfolio page.
If there's a customisation you need help with for the portfolio archive, the best place to seek advice is from the resources listed here: https://studiopress.github.io/genesis/contribute/community/
Building a plugin with only partial features doesn't reflect what Genesis developers expect from StudioPress…
You're welcome to open feature requests as new GitHub issues if there is essential functionality missing that prevents you from using the plugin. It's also fine to use other plugins/themes that better meet a particular site's needs. There are over 10,000 active installations of this plugin on sites that do find it useful, but it may not be the perfect fit for every project.
We are regularly asked for a shortcode and widget option to output portfolio items:
https://wordpress.org/support/topic/shortcode-for-widget-1/
Edited on 2018-02-12 to note additional requests:
https://wordpress.org/support/topic/genesis-protfolio-pro-wheres-the-shortcode/