Remove default parameter for `$defaults` - Githubissues

osompress / genesis-portfolio-pro

Plugin: Genesis Portfolio Pro

24 stars 14 forks source link

Remove default parameter for `$defaults` #56

Closed kienstra closed 2 years ago

kienstra commented 2 years ago

Jen found a Deprecated notice from this on PHP 8.0 and WP 6.0:

Deprecated: Optional parameter declared before required parameter is implicitly treated as a required parameter in genesis-portfolio-pro/genesis-portfolio-pro.php on line 131

Screen Shot 2022-05-16 at 12 13 47 PM

genesis_portfolio_archive_setting_defaults() is a filter callback
So the first argument shouldn't need a default, as that would mean some other filter callback mistakenly didn't return anything

How to test

Run PHP 8.1 (or maybe 8.0) and WP 6.0
Activate this plugin (no build steps like npm run dev needed)
Go to /wp-admin/plugins.php, if you're not there already
Expected: There's no PHP notice at the top of the page

Documentation

No documentation required.

Suggested changelog entry

Remove a default argument for $defaults

kienstra commented 2 years ago

Thanks, @dreamwhisper!