Add posts per page setting for portfolio Archives

[dreamwhisper]

Include a posts per page setting for Portfolio archives so it can be set independently from the standard setting.

[dreamwhisper]

Spec:

• Add setting to set the number of posts per page for archives/taxonomy archives
• Default should be 6 (or 9) to be even
• Needs filter to set the default on theme activation

[carasmo]

+1

[dreamwhisper]

@NicktheGeek I'm not sure how to handle this, but if someone has the plugin, it would be great not to change their current posts per page on update. So, maybe the default needs to just be what is currently set as posts per page.

Then, the filter can be used to update it on new theme activation.

[NicktheGeek]

@dreamwhisper it will probably bear some testing, but I've coded this so that the setting defaults to the option in the reading settings. It will require intentionally changing it to alter the value, so it won't affect it until the setting is changed.

[NicktheGeek]

@dreamwhisper I've published the release candidate branch. release/1.1 if you want to give it a test. It just includes the 3 issues here https://github.com/copyblogger/genesis-portfolio-pro/milestone/1

[dreamwhisper]

Genesis Portfolio Pro

[nickcernis]

@NicktheGeek I think this:

if ( ! $query->is_archive( 'portfolio' ) && ! $query->is_tax( 'portfolio-type' ) ) {
    return;
}

Needs to be this:

if ( ! $query->is_post_type_archive( 'portfolio' ) && ! $query->is_tax( 'portfolio-type' ) ) {
    return;
}

Here: https://github.com/copyblogger/genesis-portfolio-pro/commit/50d570617a68e218e70202611b4114b9e2d6c084#diff-55d3bf5e833c76ee6e3c2f4be15fa1cdR234

• https://developer.wordpress.org/reference/classes/wp_query/is_post_type_archive/
• https://developer.wordpress.org/reference/classes/wp_query/is_archive/ (takes no arguments)

At the moment the new setting works but it is affecting regular post category archives too:

[NicktheGeek]

updated

[nickcernis]

Confirmed: