osompress / genesis-simple-share

Plugin: Genesis Simple Share
36 stars 16 forks source link

Hotfix/object returning null #101

Closed marksabbath closed 5 years ago

marksabbath commented 5 years ago

These updates should resolve the error reported here: https://wordpress.org/support/topic/object-returning-null-wpengine-hosting/

To test this:

nickcernis commented 5 years ago

@dreamwhisper @marksabbath I think we should keep on using $genesis_simple_share now that we've changed it from $Genesis_Simple_Share, unless we see a large number of reports for it breaking functionality.

As @dreamwhisper suggested, we already know that at least one user has changed their code to use $genesis_simple_share: https://wordpress.org/support/topic/object-returning-null-wpengine-hosting/

The same user also helpfully updated the Wiki to reflect the new lowercase name, so it's now correct there too: https://github.com/studiopress/genesis-simple-share/wiki/Usage-Tips/_history

It seems fine to update the Gensis_Simple_Share_Preview class name to Genesis_Simple_Share_Preview if we want to, though. (That seems less likely to be referenced directly.)

marksabbath commented 5 years ago

It does make sense @dreamwhisper @nickcernis I'll close this PR and will work in another one to rename the class and file.