Simple Share settings conflict with Features posts widget

[katyfb13]

https://github.com/copyblogger/synthesis-platform/issues/748#issuecomment-46719572

The issue is a conflict in this specific user's simple share settings and the configuration for the Featured Posts widget which created some sharing scripts that should be there in normal circumstances. I fixed this user site but we should work on a solution in Simple Share to prevent this from happening under a similar setup.

[NicktheGeek]

ok updated this to move the icon output actions/filters so they are loaded on genesis_loop with a priority of 5 and then remove them with a priority of 15. This should effectively allow the icons only on the main loop. There may be a few times when a widget area or custom hook is on genesis_loop with a priority between 5 and 15 but I think that is more of a fringe case.

This is ready to test. To test

• [x] Setup the settings to show on posts and archives
• [x] Add a featured post widget to a sidebar and set it to show the full content or the excerpt
• [ ] Verify the icon code is not loaded. This may require checking the page source.

[katyfb13]

@dreamwhisper when you have a chance could you please take a look at this for me?

[dreamwhisper]

If I understood this correctly, the icon code is not loaded in the featured post widget with either setting. @NicktheGeek can you confirm that's what I'm looking at? Thanks!

[NicktheGeek]

yes, it should not be loading in the featured post widgets.

[dreamwhisper]

Confirmed then!

[bgardner]

Thanks @dreamwhisper -- so @NicktheGeek, is this issue (as a whole) resolved then?

[NicktheGeek]

yep, I'm gonna close it as confirmed. We are also testing on RM so if something comes up we can open this back up.

[katyfb13]

looks good to me, but @dreamwhisper will you please double check for me? http://pilot-11.preview00.rmkr.net/