osompress / genesis-simple-share

Plugin: Genesis Simple Share
36 stars 16 forks source link

Errors on HTTPS page #26

Closed bgardner closed 10 years ago

bgardner commented 10 years ago

As noted by Scott from Next GEN Gallery:

"t throws errors in the developer console of Chrome when used on a HTTPS page. For example, the NextGEN Pro checkout page we made the share buttons hidden via CSS, but the following shows in the developer console.

[blocked] The page at 'https://www.nextgen-gallery.com/checkout/' was loaded over HTTPS, but ran insecure content from 'http://cdn.api.twitter.com/1/urls/count.json?url=http%3A%2F%2Fwww.nextgen-g…kout%2F&callback=jQuery111006888644048012793_1406747581669&_=1406747581670': this content should also be loaded over HTTPS."

NicktheGeek commented 10 years ago

to test

katyfb13 commented 10 years ago

@mattlawck do we have any hourly test sites that have SSL or can we set one up?

mattlawck commented 10 years ago

@katyfb13 We will want to test this on one of our sites that has its own domain.

@NicktheGeek please confirm we need the following files to test:

Thanks!

katyfb13 commented 10 years ago

great, thanks @mattlawck

katyfb13 commented 10 years ago

@mattlawck are we going to wait to test this on package or before (tonight/tomorrow am)?

mattlawck commented 10 years ago

@katyfb13 have uploaded the updated simpleshare to one of our SSL sites for you and/or Nick to look at.

Will shoot you both logins shortly in hip chat.

cc: @NicktheGeek

mattlawck commented 10 years ago

@katyfb13 was able to test this with @NicktheGeek we can set for template ready!

katyfb13 commented 10 years ago

@mattlawck are you going to test this on package before the update?

katyfb13 commented 10 years ago

@mattlawck are you going to test this again before we release 2.0?

katyfb13 commented 10 years ago

going to call this production ready.

@mattlawck if possible we'll need to see if we can test this on a site with ssl. I may need to make sure I have a test site set up with a cert. will need that sooner or later anyway probalby

mattlawck commented 10 years ago

@katyfb13 thisisadomain.us has new deb packages and ssl installed, will Skype a login.

katyfb13 commented 10 years ago

I took a look at thisisadomain.us and the share buttons work fine. I didn't see any warnings related to the share buttons in the console. But someone who know more about this might want to take a look

I'm going to go ahead and mark this confirmed so it doesn't hold up anything though

@mattlawck @NicktheGeek @dreamwhisper

mattlawck commented 10 years ago

@katyfb13 Took a look on thisisadomain.us and confirmed this is working for me in chrome.

Over http:// the icons link with http://

screen shot 2014-09-16 at 8 07 49 pm

Over https:// the share icons link with https://

screen shot 2014-09-16 at 8 06 51 pm