Closed bgardner closed 10 years ago
to test
I can confirm that the text has been changed. However, for facebook and google+, the icon size does not expand enough to display the full word. It works properly for the others.
I see the same behavior for small and medium sizes.
For the large box, the googleplus and facebooks look like they are a little off -- they are too far right
@rafaltomal can you check this out? Thanks.
I need to change my CSS for new button texts. It was "+1" for G+ before, so it needed only a little space there.
It should be fixed now. I added some more small CSS tweaks too.
@NicktheGeek In the preview in admin it still says +1 and Like:
I can confirm here (http://themedemo.me/mobile-first/) that the spacing of the icons/text seems to be good. Just need @NicktheGeek to address the preview text in admin per @rafaltomal's suggestion.
done, looks god on my end now.
But does it look good, @NicktheGeek? :-P
thanks for fixing this guys.
confirmed and will test on package
confirmed and production ready
confirmed and production ready
From a user of the plugin, which I tend to agree:
"Awesome plugin, Brian. One minor piece of feedback, though. When you hover over the Facebook button, it says “Like” but it’s not a Like action. It should probably say “Share” instead. The same is true for the Google+ button that says, “+1″ which is the Google version of Facebook’s “Like” behavior, so clicking that should cause you to +1 the article, or else it should probably say “Share” since that’s what action it’s performing. Just minor semantics. Love it, otherwise!"