osompress / genesis-simple-share

Plugin: Genesis Simple Share
36 stars 16 forks source link

Action Copy for Various Share Buttons #28

Closed bgardner closed 10 years ago

bgardner commented 10 years ago

From a user of the plugin, which I tend to agree:

"Awesome plugin, Brian. One minor piece of feedback, though. When you hover over the Facebook button, it says “Like” but it’s not a Like action. It should probably say “Share” instead. The same is true for the Google+ button that says, “+1″ which is the Google version of Facebook’s “Like” behavior, so clicking that should cause you to +1 the article, or else it should probably say “Share” since that’s what action it’s performing. Just minor semantics. Love it, otherwise!"

NicktheGeek commented 10 years ago

to test

katyfb13 commented 10 years ago

I can confirm that the text has been changed. However, for facebook and google+, the icon size does not expand enough to display the full word. It works properly for the others.

Does not expand enough

googleplus facebook

Expands enough

twitter

I see the same behavior for small and medium sizes.

For the large box, the googleplus and facebooks look like they are a little off -- they are too far right screen shot 2014-09-03 at 6 05 32 pm

NicktheGeek commented 10 years ago

@rafaltomal can you check this out? Thanks.

rafaltomal commented 10 years ago

I need to change my CSS for new button texts. It was "+1" for G+ before, so it needed only a little space there.

rafaltomal commented 10 years ago

It should be fixed now. I added some more small CSS tweaks too.

@NicktheGeek In the preview in admin it still says +1 and Like:

image

bgardner commented 10 years ago

I can confirm here (http://themedemo.me/mobile-first/) that the spacing of the icons/text seems to be good. Just need @NicktheGeek to address the preview text in admin per @rafaltomal's suggestion.

NicktheGeek commented 10 years ago

done, looks god on my end now.

bgardner commented 10 years ago

But does it look good, @NicktheGeek? :-P

michaelbeil commented 10 years ago

thanks for fixing this guys.

katyfb13 commented 10 years ago

confirmed and will test on package

katyfb13 commented 10 years ago

confirmed and production ready

katyfb13 commented 10 years ago

confirmed and production ready