search

osompress / genesis-simple-share

Plugin: Genesis Simple Share
36 stars 16 forks source link

Double @ created if user adds @ to setting field #3

Closed NicktheGeek closed 10 years ago

NicktheGeek commented 10 years ago

Users often include @twitter_name by habit but this results in an extra @ being created. This should be removed by the script using a str_replace() to ensure the twitter ID is correctly used.

see: https://github.com/copyblogger/synthesis-platform/issues/32

fixed by: https://github.com/copyblogger/synthesis-platform/commit/07a5bb61e3541c375e0ac46963d71c3b1067c268

NicktheGeek commented 10 years ago

To test. Add @ in front of username in the Twitter option and save. It should display without the @. Click button to send tweet. It should only show one @ on the via.

@DaisyOlsen @dreamwhisper @katyfb13

dreamwhisper commented 10 years ago

confirmed 1

NicktheGeek commented 10 years ago

I'm good with closing this on confirmed 1. We are using this fix on copyblogger.com so it is confirmed there too.