share-before markup duplicated

[dreamwhisper]

The markup and script for the before content selection are duplicated in the source code, which doesn't validate.

<div class="share-before share-filled share-small" id="share-before-1222">
<div class="googlePlus" id="googleplus-before-1222" data-url="http://site.com/podcast/test-podcast/" data-urlalt="http://site.com/?p=1222" data-text="test podcast" data-title="Share"></div>
<div class="facebook" id="facebook-before-1222" data-url="http://site.com/podcast/test-podcast/" data-urlalt="http://site.com/?p=1222" data-text="test podcast" data-title="Share"></div>
<div class="pinterest" id="pinterest-before-1222" data-url="http://site.com/podcast/test-podcast/" data-urlalt="http://site.com/?p=1222" data-text="test podcast" data-title="Pin"></div>
<div class="linkedin" id="linkedin-before-1222" data-url="http://site.com/podcast/test-podcast/" data-urlalt="http://site.com/?p=1222" data-text="test podcast" data-title="Share"></div>
</div>

[dreamwhisper]

This also appears to happen with the share-player-share markup.

[dreamwhisper]

It displays the same issue on Genesis Sample in my testing.

[NicktheGeek]

@dreamwhisper sorry I am probably reading this way to early, but where is it duplicated? Is there an example I can look at?

[dreamwhisper]

@NicktheGeek links in hipchat.

I was mistaken on share-player-share - that was due to settings.

[dreamwhisper]

@NicktheGeek I finally found the setting that is causing the issue.

If you set a content limit in the Content Archive theme settings, it causes the duplication on the single post.

[TygrScott]

@dreamwhisper thanks for posting this. You helped me resolve my issue with share after duplication. Strange yours duplicated on "Share Before" mine worked fine with that setting but duplicated with "Share After." I switched my theme settings to not be content limit and it fixed for me as well.

[katyfb13]

@NicktheGeek please add some testing instructions on this

[NicktheGeek]

you will need to do the tests with various content options. Specifically you need to set the content archives for full content, full content + limit to X characters, and the excerpt.

In each scenario

• [x] check to make sure share icons show above, below, and above and below the content in the archives
• [x] check to make sure share icons show above, below, and above and below the content in the single post/page/...
• [ ] check to make sure the markup doesn't include duplicate IDs

[katyfb13]

this looks good to me now. And I am not seeing the duplicate IDs but @dreamwhisper will you please double check my work?

[katyfb13]

marked this as needs dev since it seems the fix is not there yet cc: @rrennick @NicktheGeek @dreamwhisper

[NicktheGeek]

changed it back. The fix was merged in and is showing in cbmpackage. Will be in the hourlies after the next update.

[katyfb13]

@dreamwhisper looks like the errors are gone now, but please confirm

[dreamwhisper]

Confirmed

[katyfb13]

wooo hoooo!

[r-diamond]

Confirmed and Production Ready