osompress / genesis-simple-share

Plugin: Genesis Simple Share
36 stars 16 forks source link

Way to add share by email? (Not an issue) #42

Open deluxedesigns opened 9 years ago

deluxedesigns commented 9 years ago

I'm wondering if there is a way to add a share by email option? I can customize the css if needed but the rest would be a bit above me. Thanks in advance :)

NicktheGeek commented 9 years ago

Julie,

thanks for the suggestion. It is something that can be added but tracking shares by email isn't something we can easily do for social proof so to speak. I'll leave this open but I'm not certain this is a feature we'll be adding very soon.

In the interim you could add a mailto: link via one of the genesis actions and style it to appear along side the GSS icons. If you are using Genesis Simple Hooks it should be pretty easy to add your HTML link like

<?php

     printf( 
        '<a class="simple-mail-link" href="mailto:?subject=%s&body=%s"><span class="label">tell a friend</span></a>', 
        the_title_attribute( 'echo=0' ),
        sprintf( 'I just read this amazing post I think you would like. Check it out here: %s', get_the_permalink() )
    );

?>

Paste that into one of the post entry hooks to make the link show up on posts and then you can use CSS to control how it looks including CSS positioning or margin offsets to control placement.

hmt3design commented 5 years ago

I'm very much a novice in PHP, but in trying to implement the script above, the following part seems not to be working:

the_title_attribute( 'echo=0' ), sprintf( 'I just read this amazing post I think you would like. Check it out here: %s', get_the_permalink() )

When I click on the email link, an email opens up, but the text and the permalink do not appear in the email body. Please advise.

nickcernis commented 5 years ago

@hmt3design Are you using the exact code as written above? Do you have a link to a page where the resulting link is visible?

hmt3design commented 5 years ago

I am. You can find it on my page(s) at hmt3design.com. Also, do I need to use CSS to get it to line up with the other items, or can it be (preferably) inserted into the Simple Share block?

nickcernis commented 5 years ago

@hmt3design Thanks for the link. Are you sure the code is the same as in https://github.com/studiopress/genesis-simple-share/issues/42#issuecomment-71958888 ?

The email link on your page has the &body split as a separate attribute:

Screen Shot 2019-08-21 at 19 03 28

It would be worth double-checking the code above and comparing with your own. It seems as if one of the " marks may be misplaced.

Also, do I need to use CSS to get it to line up with the other items, or can it be (preferably) inserted into the Simple Share block?

You'd need CSS for this unless you plan to edit the plugin. There are some community resources here to get help with styling adjustments if needed.

hmt3design commented 5 years ago

Okay - I didn't realize I couldn't substitute my own subject line. I had:

instead of:

Is there a way to turn the text output of the link in the email into a live link?

Harry Thomas hmt3design@gmail.com

On Wed, Aug 21, 2019 at 12:06 PM Nick Cernis notifications@github.com wrote:

@hmt3design https://github.com/hmt3design Thanks for the link. Are you sure the code is same as in #42 (comment) https://github.com/studiopress/genesis-simple-share/issues/42#issuecomment-71958888 ?

The email link on your page looks like the &body split as a separate attribute:

[image: Screen Shot 2019-08-21 at 19 03 28] https://user-images.githubusercontent.com/647669/63452377-6e5f3980-c446-11e9-9884-311a63e7970a.png

It would be worth double-checking the code above and comparing with your own. It seems as if one of the " marks may be misplaced.

Also, do I need to use CSS to get it to line up with the other items, or can it be (preferably) inserted into the Simple Share block?

You'd need CSS for this unless you plan to edit the plugin. There are some community resources here https://studiopress.github.io/genesis/contribute/community/ to get help with styling adjustments if needed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/studiopress/genesis-simple-share/issues/42?email_source=notifications&email_token=AFQDZCGJEXCIBBKBH7PI7MDQFVY2ZA5CNFSM4A3CVCBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD42NAWQ#issuecomment-523554906, or mute the thread https://github.com/notifications/unsubscribe-auth/AFQDZCC56QYTSP2UMPZAI4LQFVY2ZANCNFSM4A3CVCBA .

nickcernis commented 5 years ago

@hmt3design You could try this:

printf(
    '<a class="simple-mail-link" href="mailto:?subject=%s&body=%s"><span class="label">tell a friend</span></a>',
    urlencode( 'Link from hmt3design.com' ),
    urlencode( sprintf( 'I just read this amazing post I think you would like. Check it out here: %s', get_the_permalink() ) )
);

Is there a way to turn the text output of the link in the email into a live link?

Many email clients will make full links clickable automatically when the email is sent.