search

osompress / genesis-simple-share

Plugin: Genesis Simple Share
36 stars 16 forks source link

Add Genesis Simple Love #64

Open phpbits opened 9 years ago

phpbits commented 9 years ago

Hi,

I've successfully integrated the Genesis Simple Love Plugin : https://wordpress.org/plugins/genesis-simple-love/ . Feel free to check and contact me anytime when you need anything. Thanks!

Cheers, phpbits

NicktheGeek commented 9 years ago

@phpbits

Thanks, I added several comments. Pretty much all of it is very nitpick code standard stuff. The pull request looks good over all but ideally the text domains, and code standards should be fixed. You may find it helpful to view the comments inline on the files over randomly like they are in the pull request discussion. https://github.com/copyblogger/genesis-simple-share/pull/64/files

phpbits commented 9 years ago

Done :) Thank you for the guidelines. It's my first time forking and pulling other people's code and I'm using sublime text which doesn't follow your formatting. I'll keep this items on mind, will be very helpfull for me also. I'm sending the pull request again, apology for late response.

Cheers, phpbits