When releasing a new version of the plugin the current processes is to bump the version number in the code, merge everything from the develop branch to master, then tag the master branch with the new version.
The current CircleCI Config, in order to simplify our ability to copy it to other plugins, references the most recent tag in order to create the $VERSION environment variable.
While this worked with the tag_deploy workflow, the branch_deploy workflow (when something is merged into master) was not functioning properly. Instead of the Version number in the code matching the most recent tag, the code would be showing a new version while the tag was one behind.
This PR fixes this bug by keeping the $VERSION variable consistent. During a branch_deploy the variable will represent the new version being merged in. During a tag_deploy the version number in the code will match the new tag, and the environment variable.
This PR also, however, does mean that every plugin this CircleCI Config uses will need to be edited to ensure the proper file is being referenced when extracting the version number.
mindctrl
commented
4 years ago
When releasing a new version of the plugin the current processes is to bump the version number in the code, merge everything from the
developbranch tomaster, then tag themasterbranch with the new version.The current CircleCI Config, in order to simplify our ability to copy it to other plugins, references the most recent tag in order to create the
$VERSIONenvironment variable.While this worked with the
tag_deployworkflow, thebranch_deployworkflow (when something is merged intomaster) was not functioning properly. Instead of the Version number in the code matching the most recent tag, the code would be showing a new version while the tag was one behind.This PR fixes this bug by keeping the
$VERSIONvariable consistent. During abranch_deploythe variable will represent the new version being merged in. During atag_deploythe version number in the code will match the new tag, and the environment variable.This PR also, however, does mean that every plugin this CircleCI Config uses will need to be edited to ensure the proper file is being referenced when extracting the version number.